Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix link to the example aws policy #2998

Merged
merged 1 commit into from
Jul 16, 2024
Merged

docs: fix link to the example aws policy #2998

merged 1 commit into from
Jul 16, 2024

Conversation

reubenmiller
Copy link
Contributor

@reubenmiller reubenmiller commented Jul 15, 2024 •
edited
Loading

Proposed changes

Use a static link to the example aws policy as the relative link resulted in a 404 request, for example:

image

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@reubenmiller
fix aws policy example link
cb766af 
Signed-off-by: Reuben Miller <[email protected]>
@reubenmiller reubenmiller temporarily deployed to Test Pull Request July 15, 2024 17:28 — with GitHub Actions Inactive
@reubenmiller reubenmiller added documentation Improvements or additions to documentation theme:aws Theme: AWS cloud related topics labels Jul 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
476 0 3 476 100 1h12m1.673243999s

@reubenmiller reubenmiller changed the title docs: fix aws policy example link docs: fix link to the example aws policy Jul 15, 2024
@reubenmiller reubenmiller added this pull request to the merge queue Jul 16, 2024
Merged via the queue into thin-edge:main with commit 4916fd0 Jul 16, 2024
31 checks passed
@reubenmiller reubenmiller deleted the docs-fix-aws-policy-example branch July 18, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gligorisaev gligorisaev gligorisaev approved these changes

@didier-wenzek didier-wenzek Awaiting requested review from didier-wenzek didier-wenzek is a code owner

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation theme:aws Theme: AWS cloud related topics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reubenmiller @gligorisaev